Parse almost-any sacct output #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables parsing almost-any sacct output. Summary: - auto-detect header in input CSV and extract field names - flexible SchedulerJobInfo creation SchedulerJobInfo: - support more fields: user, state, timelimit, ru_ttime - modify to_dict() to return all fields, move '*_dt' pruning into fields() SchedulerLogParser: - do not initialise output CSV in __init__(). Instead, do when writing output - modify _get_job_field_names() to accept job as optional argument, from which it takes field names - replace _write_csv_header() with _init_csv_output() SlurmLogParser: - auto-detect if input CSV has header, if yes replace SLURM_ACCT_FIELDS, and skip during parsing - redo _create_job_from_job_fields() to handle almost-any 'sacct' output and create a SchedulerJobInfo() - add parse_jobs_to_dict(), an alternative to file output Fix handling of Slurm jobs with a prolog. For me, these are categorised as FAILED because only the prolog part is COMPLETED. So retain the last State value, not first.
…celled before start)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #100
This enables parsing almost-any
sacctoutput. Summary:SchedulerJobInfocreationSchedulerJobInfo:
to_dict()to return all fields, move*_dtpruning intofields()SchedulerLogParser:
__init__(). Instead, do when writing output_get_job_field_names()to accept job as optional argument, from which it takes field names_write_csv_header()with_init_csv_output()SlurmLogParser:
SLURM_ACCT_FIELDS, and skip header during parsing_create_job_from_job_fields()to handle almost-anysacctoutput and create aSchedulerJobInfo()parse_jobs_to_dict(), an alternative to file output (so I can feed direct into Pandas)Fix handling of Slurm jobs with an epilog. For me, these are categorised as FAILED because only the epilog is COMPLETED. So retain the last State value, not first.